Add hardware support for Lenovo LOQ 15aph8 #1206
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # Lenovo LOQ 15APH8 | ||
|
|
||
| Tested on LOQ 15APH8 (82XT) with: | ||
| - AMD Phoenix GPU | ||
| - NVIDIA GeForce RTX 4050 Max-Q | ||
| - AMD Phoenix1 integrated graphics | ||
|
|
||
| ## Features Requiring Configuration | ||
| For optimal power management, consider adding: | ||
|
|
||
| ```nix | ||
| services.power-profiles-daemon.enable = true; | ||
| powerManagement.powertop.enable = true; | ||
| ``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| { lib, ...}: { | ||
| imports = [ | ||
| ../../../common/cpu/amd/pstate.nix | ||
| ../../../common/gpu/nvidia/prime.nix | ||
| ../../../common/gpu/nvidia/ada-lovelace | ||
| ../../../common/pc/laptop | ||
| ../../../common/pc/laptop/ssd | ||
| ]; | ||
|
|
||
| hardware.nvidia.prime = { | ||
| amdgpuBusId = lib.mkDefault "PCI:5:0:0"; | ||
| nvidiaBusId = lib.mkDefault "PCI:1:0:0"; | ||
| }; | ||
|
|
||
| # Power management - using mkDefault as these can be overridden | ||
| hardware.nvidia.powerManagement.enable = lib.mkDefault true; | ||
| hardware.nvidia.modesetting.enable = lib.mkDefault true; | ||
| services.thermald.enable = lib.mkDefault true; | ||
|
|
||
| # These will merge with user settings, so no mkDefault needed | ||
|
There was a problem hiding this comment. How does it merge with user settings? As far as I can see this requires 'lib.mkForce', no? |
||
| hardware.amdgpu.initrd.enable = true; | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC the
nvidia.modesettingline is implied by the call togpu/nvidia/ada-lovelace, as it callsgpu/nvidia, containing this same line.(Notably the mentioned PR there is already merged)