Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vulkan on Gaze18 #1182

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

matteobongio
Copy link
Contributor

Description of changes

Finally managed to get vulkan to work on the Gaze18

Things done

changed the boot.initrd.kernelModules

  • [ x] Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

@Mic92
Copy link
Member

Mic92 commented Oct 19, 2024

@mergify queue

Copy link
Contributor

mergify bot commented Oct 19, 2024

queue

🛑 The pull request has been removed from the queue default

Pull request #1182 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@Mic92
Copy link
Member

Mic92 commented Oct 19, 2024

@mergify dequeue

Copy link
Contributor

mergify bot commented Oct 19, 2024

dequeue

✅ The pull request has been removed from the queue default

@@ -6,7 +6,7 @@
../../common/gpu/nvidia/ampere
];

boot.initrd.kernelModules = [ "nvidia" ];
boot.initrd.kernelModules = [ "nvidia" "i915" "nvidia_modeset" "nvidia_drm" ];
Copy link
Member

@Mic92 Mic92 Oct 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment here, how this fixes vulkan support? We had recently a discussion that about whether we should have nvidia in the initrd because it adds to the initrd size. So maybe it would be better if it would be made explicit here, that for this profile it's actually needed.

@Mic92 Mic92 marked this pull request as draft October 31, 2024 09:05
@Mic92
Copy link
Member

Mic92 commented Oct 31, 2024

Please undraft when you think this is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants