Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give myself access to non-critical infra #486

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

jfly
Copy link
Contributor

@jfly jfly commented Sep 30, 2024

I'm going to be working on #485. This will give me the power to do most of the work there, except for deploying the relevant DNS changes with Terraform.

@jfly jfly requested a review from a team as a code owner September 30, 2024 20:30
I'm going to be working on <NixOS#485>.
This will give me the power to do most of the work there, except for
deploying the relevant DNS changes with Terraform.
@jfly jfly force-pushed the give-myself-access-to-non-critical-infra branch from 8eb0cc7 to 7699672 Compare September 30, 2024 20:47
@Mic92
Copy link
Member

Mic92 commented Oct 10, 2024

So @mweinelt and @vcunat abstain providing their feedback on this pull request, because they don't know @jfly. I am going to merge this Friday, so we can proceed with our work.

@vcunat
Copy link
Member

vcunat commented Oct 10, 2024

I'd say I'm in a "no objection" position.

We do need to be able to onboard people that aren't too well known. If the non-critical infra isn't very suitable for that, perhaps we should move those parts to the other sub-team. (the team member sets are equal right now anyway)

@Mic92 Mic92 merged commit 3db6041 into NixOS:master Oct 11, 2024
3 checks passed
@Mic92
Copy link
Member

Mic92 commented Oct 11, 2024

Your key has been deployed.

@jfly jfly deleted the give-myself-access-to-non-critical-infra branch October 28, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants