renderInputDiff: Increase git hash length 8 -> 12 #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See investigation on lengths required to be conflict-free in practice: NixOS#1258 (comment)
SuperSandro2000
approved these changes
Jul 21, 2024
Mindavi
approved these changes
Jul 22, 2024
tomberek
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See investigation on lengths required to be conflict-free in practice:
#1258 (comment)
Reason: Got annoyed / slowed down today again that the commit
c716603ashown in https://hydra.nixos.org/build/266559156 shows 404 on Github: NixOS/nixpkgs@c716603aThis immediately made me suspect that somebody rewrote history (security issue), when in fact the commit is just too short.
We should not waste time with such things, so bump the length.