-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VgpuTypeIDToUint32 helper function #129
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
// Copyright (c) 2020, NVIDIA CORPORATION. All rights reserved. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package nvml | ||
|
||
func (vgpuTypeId *nvmlVgpuTypeId) Extensions() ExtendedVgpuTypeId { | ||
return vgpuTypeId | ||
} | ||
|
||
// ID returns the numeric representaion of the vgpuTypeId. | ||
func (vgpuTypeId *nvmlVgpuTypeId) ID() uint32 { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think |
||
if vgpuTypeId == nil { | ||
return 0 | ||
} | ||
return uint32(*vgpuTypeId) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -583,7 +583,6 @@ type Interface interface { | |
EventSetCreate() (EventSet, Return) | ||
EventSetFree(EventSet) Return | ||
EventSetWait(EventSet, uint32) (EventData, Return) | ||
Extensions() ExtendedInterface | ||
GetExcludedDeviceCount() (int, Return) | ||
GetExcludedDeviceInfoByIndex(int) (ExcludedDeviceInfo, Return) | ||
GetVgpuCompatibility(*VgpuMetadata, *VgpuPgpuMetadata) (VgpuPgpuCompatibility, Return) | ||
|
@@ -668,6 +667,7 @@ type Interface interface { | |
VgpuTypeGetName(VgpuTypeId) (string, Return) | ||
VgpuTypeGetNumDisplayHeads(VgpuTypeId) (int, Return) | ||
VgpuTypeGetResolution(VgpuTypeId, int) (uint32, uint32, Return) | ||
Extensions() ExtendedInterface | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why / how did this get generated at the bottom? The generation code sorts the functions alphabetically ... |
||
} | ||
|
||
// Device represents the interface for the nvmlDevice type. | ||
|
@@ -1004,4 +1004,5 @@ type VgpuTypeId interface { | |
GetNumDisplayHeads() (int, Return) | ||
GetResolution(int) (uint32, uint32, Return) | ||
GetSupportedPlacements(Device) (VgpuPlacementList, Return) | ||
Extensions() ExtendedVgpuTypeId | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
vgpuTypeId
doesn't have to be a pointer receiver.