Fix for Host code binary operation. #1855
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for xor_and_popc and and_and_popc in array.h
Add and_popc_add and xor_popc_add to functional.
Replaced add_add with and_popc_add as Operator is `OpAndPopc` not 'OpAndAdd`. Same for xor_add
|
This PR has been labeled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Host code using
OpAndPopcwhile operation done in the backend isand_addsame for xor. Suggesting to add another Operator in arch.h forOpAndAddandOpXorAddand renamaingOpAndPopctoOpAndPopcAdd