Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open-source tensornet simulator and add tensornet-mps simulator backend #863

Merged
merged 17 commits into from
Nov 9, 2023
Merged

Open-source tensornet simulator and add tensornet-mps simulator backend #863

merged 17 commits into from
Nov 9, 2023
+1,688 −10

Conversation

1tnguyen
Copy link
Collaborator

@1tnguyen 1tnguyen commented Nov 6, 2023 •
edited
Loading

Description

  • Add tensornet and mps backends based on cuquantum 23.10 release.

  • Modified Dockerfile to use the the latest cuquantum.

  • Include the new backends in the runtime test suite: escaping some tests that are not suitable for tensornet backends: conditional circuits with many shots (long test time) and multi-qubit (> 2) gates on MPS.

@1tnguyen 1tnguyen mentioned this pull request Nov 6, 2023
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 6, 2023
@cuda-quantum-bot
Docs preview for PR #863.
33957e3
@1tnguyen 1tnguyen marked this pull request as ready for review November 6, 2023 03:47
@1tnguyen 1tnguyen added this to the release 0.5.0 milestone Nov 6, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 6, 2023
@cuda-quantum-bot
Docs preview for PR #863.
e71cc88
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 7, 2023
@cuda-quantum-bot
Docs preview for PR #863.
0e77134
bmhowe23
bmhowe23 reviewed Nov 8, 2023
View reviewed changes
runtime/nvqir/cutensornet/simulator_cutensornet.cpp Show resolved Hide resolved
runtime/nvqir/cutensornet/simulator_cutensornet.cpp Show resolved Hide resolved
runtime/nvqir/cutensornet/simulator_cutensornet.cpp Outdated Show resolved Hide resolved
runtime/nvqir/cutensornet/tensornet_spin_op.cpp Outdated Show resolved Hide resolved
runtime/nvqir/cutensornet/tensornet_spin_op.cpp Outdated Show resolved Hide resolved
runtime/nvqir/cutensornet/tensornet_state.cpp Outdated Show resolved Hide resolved
runtime/nvqir/cutensornet/tensornet_state.cpp Outdated Show resolved Hide resolved
runtime/nvqir/cutensornet/tensornet_state.cpp Outdated Show resolved Hide resolved
runtime/nvqir/cutensornet/tensornet_state.cpp Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 8, 2023
@cuda-quantum-bot
Docs preview for PR #863.
04d0e93
@1tnguyen
Copy link
Collaborator Author

1tnguyen commented Nov 9, 2023

Test logs for the runtime test suite (unittests/) for these 2 backends:

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 9, 2023
@cuda-quantum-bot
Docs preview for PR #863.
4375b10
@bettinaheim bettinaheim mentioned this pull request Nov 9, 2023
Closed
bettinaheim
bettinaheim approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@bettinaheim bettinaheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@1tnguyen
Fix a couple of compiler warnings on Clang
f2bdf37 
Thanks @bmhowe23 for spotting them.

- Dead `default` switch case. Clang doesn't like it.

- Missing a default virtual destructor and one inconsistent declaration.

- Update the example to be generic with/without cutensornet MPI support.
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 9, 2023
@cuda-quantum-bot
Docs preview for PR #863.
88d8850
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 9, 2023
@cuda-quantum-bot
Docs preview for PR #863.
f2951ad
bmhowe23
bmhowe23 approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Thien 👍

@khalatepradnya
Copy link
Collaborator

Q: Do these simulator backends have configuration files?

@1tnguyen
Copy link
Collaborator Author

1tnguyen commented Nov 9, 2023

Q: Do these simulator backends have configuration files?

Yes, they have. The config files are auto generated and installed by CMake.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 9, 2023
@cuda-quantum-bot
Docs preview for PR #863.
8b532aa
@1tnguyen 1tnguyen merged commit a8123e4 into NVIDIA:main Nov 9, 2023
105 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
@bettinaheim bettinaheim added the enhancement New feature or request label Nov 15, 2023
@bettinaheim bettinaheim changed the title Add cutensornet-based simulator backends Open-source tensornet simulator and add tensornet-mps simulator backend. Nov 15, 2023
@bettinaheim bettinaheim changed the title Open-source tensornet simulator and add tensornet-mps simulator backend. Open-source tensornet simulator and add tensornet-mps simulator backend Nov 15, 2023
@bettinaheim bettinaheim added the no release notes Don't list this PR in the release notes label Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bmhowe23 bmhowe23 bmhowe23 approved these changes

@bettinaheim bettinaheim bettinaheim approved these changes

@anthony-santana anthony-santana Awaiting requested review from anthony-santana

@amccaskey amccaskey Awaiting requested review from amccaskey

@schweitzpgi schweitzpgi Awaiting requested review from schweitzpgi

Assignees
No one assigned
Labels
enhancement New feature or request no release notes Don't list this PR in the release notes
Projects
None yet
Milestone
release 0.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@1tnguyen @khalatepradnya @bettinaheim @bmhowe23