python/metapackages/setup.py: improve package conflict detection #2399
+94
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchdz
requested review from
bettinaheim,
1tnguyen and
bmhowe23
as code owners
sacpis
reviewed
Nov 21, 2024
sacpis
reviewed
Nov 21, 2024
Comment on lines
+134
to
+135
| search_pattern = os.path.join(directory, f"{package_name}-*.dist-info") | ||
| matches = glob.glob(search_pattern) |
There was a problem hiding this comment.
Wondering if we can just search a file in a directory. Or am I misunderstanding something?
There was a problem hiding this comment.
I didn't find a great file to specifically look for that all installed packages would have. The consistent one was ${package_name}-${version}.dist-info which contains the metadata for the package.
Command Bot: Processing... |
Command Bot: Processing... |
|
FYI - I added a short one line commit to fix the cuda-quantum package README. |
Command Bot: Processing... |
Command Bot: Processing... |
Command Bot: Processing... |
1 similar comment
Command Bot: Processing... |
.github/workflows/python_metapackages.yml: enable previous disabled test Signed-off-by: mitchdz <[email protected]>
Because the test runners do not have a GPU, the default bdist choice of cuda-quantum-cu12 is always chosen, which breaks some of the tests. Credit: Bettina Heim Signed-off-by: mitchdz <[email protected]>
The README had an echo with grave symbols which spawned a subshell to execute the command which returned nothing - thus creating an empty string. This resulted in the README saying: "...new versions are published under the name instead..." Now it will say: "...new versions are published under the name `cudaq` instead..." Signed-off-by: mitchdz <[email protected]>
At the end of the test, install_default is compared to test_conflicting, but installed_default is not printed anywhere in the logs. Signed-off-by: mitchdz <[email protected]>
Modify the logic to only take the first occurence of the Identified best package. This is because setup.py prints out the package multiple times like so: [cudaq] Identified cuda-quantum-cu12 as the best package. [cudaq] Identified cuda-quantum-cu12 as the best package. [cudaq] Identified cuda-quantum-cu12 as the best package. Which will make installed_default="cuda-quantum-cu12 cuda-quantum-cu12 cuda-quantum-cu12" which fails the logic test for the CI. This Identified package should be the same for all prints, so the first occurence is taken. Signed-off-by: mitchdz <[email protected]>
Command Bot: Processing... |
bettinaheim
approved these changes
Nov 23, 2024
Command Bot: Processing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pip installThis code specifically checks the following packages:
cuda-quantum,cuda-quantum-cu11,cuda-quantum-cu12during the package installation phase ofpip install.For example, with
cuda-quantum-cu11installed andcuda12libraries installed, attempting topip install cudaqwill give: