Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two-stream finidat type restart fixes #1286

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

rgknox
Copy link
Contributor

@rgknox rgknox commented Nov 16, 2024

Description:

This set of changes fixes some problems with getting two-stream restarted when using an finidat file (ie non continue_run style). Changes are associated with zenith angle and the signaling during the restart to initialize data structures. This also simplifies how we import (from the host) and use zenith angles (site level zenith angle instead of patch, and removal of superfluous zenith angle flag).

This is an API changing PR, and will need associated PRs on the host side.

Collaborators:

@ckoven

Expectation of Answer Changes:

Should only change two-stream results (will will re-evaluate).

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@rgknox rgknox added the PR status: Not Ready The author is signaling that this PR is a work in progress and not ready for integration. label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR status: Not Ready The author is signaling that this PR is a work in progress and not ready for integration.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants