-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(gradle): update Gradle and dependencies #715
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a logical first step, however, it will break running older releases with these changes. The launcher will need the ability to launch the game using multiple different JREs to keep those older builds functional. From my perspective, that can be implemented separately from this change.
For this pull request though, the only changes I require are to use Java 17 JREs instead of Java 21 ones. Although I've tried to keep Java 21 working, we're not supporting it officially yet and we don't test it much during development.
src/main/java/org/terasology/launcher/repositories/GithubRepository.java
Show resolved
Hide resolved
Co-authored-by: BenjaminAmos <[email protected]>
Co-authored-by: BenjaminAmos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I see this correctly this is just upgrading Gradle and dependencies, and using Java 17 (which should all still be fine for the older games, right?).
So, let's get this merged, and let's try to make the launcher actively handle JREs for the games to (as previous PRs already prepared for that).
To prepare for upgrading to newer Java versions and generally keep the launcher's dependencies up-to-date this PR does