Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(gradle): update Gradle and dependencies #715

Merged
merged 11 commits into from
Jun 21, 2024
Merged

Conversation

soloturn
Copy link
Contributor

@soloturn soloturn commented Jun 16, 2024

To prepare for upgrading to newer Java versions and generally keep the launcher's dependencies up-to-date this PR does

  • fix the Artifactory URL
  • update Gradle 8.8
  • update build jobs to use Java 17
  • update dependencies

Copy link
Contributor

@BenjaminAmos BenjaminAmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a logical first step, however, it will break running older releases with these changes. The launcher will need the ability to launch the game using multiple different JREs to keep those older builds functional. From my perspective, that can be implemented separately from this change.

For this pull request though, the only changes I require are to use Java 17 JREs instead of Java 21 ones. Although I've tried to keep Java 21 working, we're not supporting it officially yet and we don't test it much during development.

.idea/misc.xml Outdated Show resolved Hide resolved
config/gradle/jre.gradle Outdated Show resolved Hide resolved
@skaldarnar skaldarnar changed the title java and gradle upgrade build(gradle): update Gradle and dependencies Jun 21, 2024
Copy link
Member

@skaldarnar skaldarnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I see this correctly this is just upgrading Gradle and dependencies, and using Java 17 (which should all still be fine for the older games, right?).

So, let's get this merged, and let's try to make the launcher actively handle JREs for the games to (as previous PRs already prepared for that).

@skaldarnar skaldarnar marked this pull request as ready for review June 21, 2024 15:34
@skaldarnar skaldarnar added Topic: CI/CD Related to CI/CD and build infrastructure (excluded from the Changelog) Type: Maintenance Maintenance or chores not adding new features or fixing bugs. labels Jun 21, 2024
@skaldarnar skaldarnar merged commit 8237b1e into master Jun 21, 2024
3 checks passed
@skaldarnar skaldarnar deleted the gradle-upgrade branch June 21, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: CI/CD Related to CI/CD and build infrastructure (excluded from the Changelog) Type: Maintenance Maintenance or chores not adding new features or fixing bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants