chore: remove unnecessary props

MoePlayer · Aug 8, 2019 · 86bd53d · 86bd53d
1 parent 741d1ba
commit 86bd53d
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 7 deletions.
diff --git a/declaration/caraoke.d.ts b/declaration/caraoke.d.ts
@@ -1,6 +1,5 @@
 import { Option, LyricItem } from "./caraoke.interface.js";
 export default class Caraoke {
-    private audioNode;
     private container;
     private lyric;
     private view;

diff --git a/declaration/caraoke.interface.d.ts b/declaration/caraoke.interface.d.ts
@@ -1,5 +1,4 @@
 export interface Option {
-    audio: HTMLMediaElement;
     container: HTMLElement;
     lyric?: LyricItem[];
 }

diff --git a/dist/caraoke.js b/dist/caraoke.js
@@ -3,7 +3,6 @@ import CaraokeView from "./view.js";
 export default class Caraoke {
     constructor(defaultOptions) {
         defaultOptions.lyric && (this.lyric = defaultOptions.lyric);
-        this.audioNode = defaultOptions.audio;
         this.container = defaultOptions.container;
         CaraokeView.install();
         this.view = new CaraokeView;

diff --git a/src/caraoke.interface.ts b/src/caraoke.interface.ts
@@ -1,5 +1,4 @@
 export interface Option {
-    audio: HTMLMediaElement;
     container: HTMLElement;
     lyric?: LyricItem[];
 }

diff --git a/src/caraoke.ts b/src/caraoke.ts
@@ -10,7 +10,6 @@ import CaraokeView from "./view.js";
  *  An alternative karaoke presentation module.
  */
 export default class Caraoke {
-    private audioNode: HTMLMediaElement;
     private container: HTMLElement;
     private lyric: LyricItem[];
     private view: CaraokeView;
@@ -20,7 +19,6 @@ export default class Caraoke {
     }
     constructor(defaultOptions: Option) {
         defaultOptions.lyric && (this.lyric = defaultOptions.lyric);
-        this.audioNode = defaultOptions.audio;
         this.container = defaultOptions.container;
         CaraokeView.install()
         this.view = new CaraokeView;

diff --git a/test/public/index.html b/test/public/index.html
@@ -10,7 +10,7 @@
     <audio src="https://localhost/example.music" id="mediaPlayer" controls></audio>
     <script type="module">
         import Caraoke from "/dist/caraoke.js";
-        const c = new Caraoke({audio:mediaPlayer,container:document.body});
+        const c = new Caraoke({container:document.body});
         c.setLyric(JSON.parse(`MusicLyric.as.LyricItem[]`));
         mediaPlayer.addEventListener("timeupdate",()=>c.render(mediaPlayer.currentTime))
 </script>