Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add article "WinUI 3 (Windows App SDK) sample app" #3302

Merged
merged 20 commits into from
Nov 7, 2024

Conversation

mikehoffms
Copy link
Contributor

@mikehoffms mikehoffms commented Nov 6, 2024

Rendered article for review:

Related PR:

  • PR 258 (WinUI 3 sample: Update Readme and fixed-version Runtime code) in WebView2Samples repo

AB#54887339
AB#54887352 - Samples repo PR

@mikehoffms mikehoffms added the cat: webview2 WebView-related content. label Nov 6, 2024
Copy link
Contributor

@captainbrosset captainbrosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't do a technical check on this as I don't have the right expertise. But the content looks good to me.

microsoft-edge/webview2/samples/webview2-winui3-sample.md Outdated Show resolved Hide resolved
Copy link
Contributor

@peiche-jessica peiche-jessica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@captainbrosset captainbrosset merged commit 960888a into main Nov 7, 2024
2 checks passed
@captainbrosset captainbrosset deleted the user/mikehoffms/winui3-sample branch November 7, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: webview2 WebView-related content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants