Support virtual_modules #47
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wavewave
added a commit
to MercuryTechnologies/buck2-ghc-build
that referenced
this pull request
Sep 27, 2024
based on MercuryTechnologies/buck2-prelude#47 * retry ghc-prim build. now -this-unit-id ghc-prim with use_same_package_name=True. a little bit more progress. * Success in building ghc-prim and ghc-bignum, ghc-internal depending on that in-tree lib! by virtual_modules = ["GHC.Prim"] * remove hard-coded paths (unnecessary) * remove irrelevant comment now
to use the specified name as GHC package name. In some special cases (especially GHC boot libraries), the package name needs to be given as specified.
wavewave
force-pushed
the
wavewave/no-more-special-base
branch
from
c2198e3
to
8f5f116
Compare
the same as Cabal virtual-modules. This is necessary to support ghc-prim compilation.
wavewave
force-pushed
the
wavewave/virtual_modules
branch
from
b599821
to
55583a6
Compare
wavewave
force-pushed
the
wavewave/no-more-special-base
branch
from
8f5f116
to
403c8e4
Compare
wavewave
force-pushed
the
wavewave/no-more-special-base
branch
from
403c8e4
to
97d5d1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the same as Cabal virtual-modules. This is necessary to support ghc-prim compilation.
The modules listed in
virtual_modulesare added to exposed modules in package.conf without actual source codes.