Issue 43/rename bonus credits to bonus reserves #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changing BonusReserve.game_id to be a foreign key on Game.id
…nus-credits-to-bonus-reserves
…e corresponding class name
…" (instead of automatic "bonus_reserf"...), and fixing multiple initialization problems
gsaint
commented
May 9, 2017
| @@ -167,7 +168,8 @@ | |||
| add_index "users", ["team_id"], name: "index_users_on_team_id", using: :btree | |||
| add_index "users", ["team_role_id"], name: "index_users_on_team_role_id", using: :btree | |||
|
|
|||
| add_foreign_key "bonus_credits", "teams" | |||
| add_foreign_key "bonus_reserves", "games" | |||
| add_foreign_key "bonus_reserves", "teams" | |||
There was a problem hiding this comment.
I added in this file some missing index (bonus_reserves.game_id) and foreign keys (game_id.games and game_id.teams).
gsaint
commented
May 9, 2017
|
|
||
| ActiveSupport::Inflector.inflections do |inflect| | ||
| inflect.irregular 'bonus_reserve', 'bonus_reserves' | ||
| end |
There was a problem hiding this comment.
So much fun with this one... Rails was creating routes with a wrong singularization, and was also unable to properly initialize the Game model as it was expecting "bonus_reserf" to be the singularization of "bonus_reserves"... Took me some time to understand where it came from!
There was a problem hiding this comment.
:o that's crazy go nuts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue 43: #43