Delete invalid nil timestamp event streams #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrafanie
force-pushed
the
delete_nil_timestamp_event_streams
branch
3 times, most recently
from
b31b299
to
ba9538d
Compare
Fryguy
reviewed
Aug 30, 2023
db/migrate/20230830134742_delete_nil_timestamp_event_streams.rb
Outdated
Show resolved
Hide resolved
jrafanie
force-pushed
the
delete_nil_timestamp_event_streams
branch
from
ba9538d
to
e5f65aa
Compare
agrare
reviewed
Aug 30, 2023
|
|
||
| migrate | ||
|
|
||
| expect(event_stream_stub.pluck(:id, :timestamp).flatten).to eq([good.id, good.timestamp]) |
There was a problem hiding this comment.
This is failing on timestamp precision,
1) DeleteNilTimestampEventStreams#up removes nil timestamp events, leaving others
Failure/Error: expect(event_stream_stub.pluck(:id, :timestamp).flatten).to eq([good.id, good.timestamp])
expected: [4, 2023-08-30 17:33:20.160235809 +0000]
got: [4, 2023-08-30 17:33:20.160235000 +0000]
There was a problem hiding this comment.
ok, I was hoping to keep it simple. I guess I can check that's not nil.
There was a problem hiding this comment.
You could use .to be_within() or .to_i both
There was a problem hiding this comment.
Thanks, I went with present since that's the intention of it.
Until ManageIQ/manageiq-providers-kubernetes#501 code lands, openshift events with nil timestamps will be added to event streams. These are invalid events and really mess up our queries since we timestamp is a lookup field and expected to use an index which doesn't happen when it's nil.
jrafanie
force-pushed
the
delete_nil_timestamp_event_streams
branch
from
e5f65aa
to
2ba5fb1
Compare
agrare
approved these changes
Aug 30, 2023
|
Checked commit jrafanie@2ba5fb1 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
|
Backported to |
Fryguy
pushed a commit
that referenced
this pull request
Sep 12, 2023
Delete invalid nil timestamp event streams (cherry picked from commit acfb86d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until ManageIQ/manageiq-providers-kubernetes#501 code lands, openshift events with nil timestamps will be added to event streams.
These are invalid events and really mess up our queries since we timestamp is a lookup field and expected to use an index which doesn't happen when it's nil.