Merge pull request #4 from Makuna/cleanup

support and cleanup
Makuna · May 29, 2019 · f7c106e · f7c106e
2 parents a366d1c + 17d419d
commit f7c106e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/SUPPORT.md b/SUPPORT.md
@@ -0,0 +1,8 @@
+# Support
+
+For questions and help, jump on Gitter and ask away.  
+[![Gitter](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/Makuna/Rfid134?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
+
+For documentation [See the Wiki](https://github.com/Makuna/Rfid134/wiki)
+
+For bugs, make sure there isn't an active issue and then create one.  Understand that issues are for bugs found in the library and not issues you are having with the library.  
diff --git a/src/Rfid134.h b/src/Rfid134.h
@@ -133,16 +133,12 @@ template<class T_SERIAL_METHOD, class T_NOTIFICATION_METHOD> class Rfid134
 
         if (static_cast<uint8_t>(~checksum) != static_cast<uint8_t>(packet[Rfid134_Packet_CheckSumInvert]))
         {
-            Serial.print("ERROR: packetChecksumInvert missmatch ");
-            Serial.print(static_cast<uint8_t>(~checksum));
-            Serial.print(" != ");
-            Serial.println(static_cast<uint8_t>(packet[Rfid134_Packet_CheckSumInvert]));
             return Rfid134_Error_PacketChecksumInvert;
         }
 
         Rfid134Reading reading;
 
-        // convert hex LSB ascii to number
+        // convert packet into the reading struct
         reading.id = HexLsbAsciiToUint64(&(packet[Rfid134_Packet_Id]), Rfid134_Packet_Country - Rfid134_Packet_Id);
         reading.country = HexLsbAsciiToUint64(&(packet[Rfid134_Packet_Country]), Rfid134_Packet_DataFlag - Rfid134_Packet_Country);
         reading.isData = packet[Rfid134_Packet_DataFlag] == '1';