Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smg spread #1356

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Smg spread #1356

wants to merge 2 commits into from

Conversation

Themostrandom
Copy link
Contributor

--> spread = 2 --> spread = 1.3

reduce spread 2 --> 1.3
@Themostrandom
Copy link
Contributor Author

@farooqkz
Copy link
Contributor

farooqkz commented Nov 17, 2024

I can also add this https://discord.com/channels/447819017391046687/1008040841102766153/1276904968581939254

In general, one change per PR. I also get tempted to do some small stuff through one PR but it's usually not a good idea.

I feel like 1.5 is a better choice than 1.3 as the current one is 2

@Themostrandom
Copy link
Contributor Author

I can also add this https://discord.com/channels/447819017391046687/1008040841102766153/1276904968581939254

In general, one change per PR. I also get tempted to do some small stuff through one PR but it's usually not a good idea.

I feel like 1.5 is a better choice than 1.3 as the current one is 2

okay

@Themostrandom
Copy link
Contributor Author

I can also add this https://discord.com/channels/447819017391046687/1008040841102766153/1276904968581939254

In general, one change per PR. I also get tempted to do some small stuff through one PR but it's usually not a good idea.

I feel like 1.5 is a better choice than 1.3 as the current one is 2

Its done spread= 1.5 now

@farooqkz
Copy link
Contributor

@LoneWolfHT Merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants