-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow donating maximum score by donating 0 or less #1350
Conversation
Hello! Nice doing. However I don't like using |
That would be more complicated since you'd have to also check if 'max' is a player name and figure out how to handle that |
Maybe |
I'm fine with either method, although 0 shouldn't turn into the max amount |
now it should take :max or negative numbers, and I added a line to the description explaining that |
Code looks good to me. |
Suggestion
This should allow players to donate half their score by using 0 or any negative number as the donation amount. I've tested it as well as I can.