Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow donating maximum score by donating 0 or less #1350

Merged
merged 5 commits into from
Nov 10, 2024

Conversation

lazylier
Copy link
Contributor

@lazylier lazylier commented Nov 2, 2024

  • This PR has been tested locally

Suggestion

This should allow players to donate half their score by using 0 or any negative number as the donation amount. I've tested it as well as I can.

@farooqkz
Copy link
Contributor

farooqkz commented Nov 3, 2024

Hello! Nice doing. However I don't like using 0 or negative numbers for this. I would prefer max for this. like /donate LandarVargan max to donate the maximum amount you can donate. I will review code after you've changed this. Cheers!

@lazylier
Copy link
Contributor Author

lazylier commented Nov 3, 2024

Hello! Nice doing. However I don't like using 0 or negative numbers for this. I would prefer max for this. like /donate LandarVargan max to donate the maximum amount you can donate. I will review code after you've changed this. Cheers!

That would be more complicated since you'd have to also check if 'max' is a player name and figure out how to handle that

@farooqkz
Copy link
Contributor

farooqkz commented Nov 3, 2024

Maybe :max?

@LoneWolfHT
Copy link
Member

I'm fine with either method, although 0 shouldn't turn into the max amount

@lazylier
Copy link
Contributor Author

lazylier commented Nov 3, 2024

now it should take :max or negative numbers, and I added a line to the description explaining that

@farooqkz
Copy link
Contributor

farooqkz commented Nov 4, 2024

Code looks good to me.

@LoneWolfHT LoneWolfHT merged commit a01635a into MT-CTF:master Nov 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants