Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mushroom farming #1304

Closed
wants to merge 15 commits into from
Closed

Add mushroom farming #1304

wants to merge 15 commits into from

Conversation

farooqkz
Copy link
Contributor

  • This PR has been tested locally

This PR is a draft because I think it needs more polish. Or it might not need. Reviews are very welcome!

@farooqkz farooqkz marked this pull request as ready for review June 18, 2024 09:04
@LoneWolfHT
Copy link
Member

LoneWolfHT commented Jun 26, 2024

What do you get if you time the per-step lua time with (endtime - starttime) / 1e6 using minetest.get_us_time() for the times; Placing a lot of mushrooms to test with?

@farooqkz
Copy link
Contributor Author

What do you get if you time the per-step lua time with (endtime - starttime) / 1e6 using minetest.get_us_time() for the times; Placing a lot of mushrooms to test with?

Not sure what you mean. Are you suggesting using this method instead of the current method with globalstep? BTW, This PR spawns mushrooms anywhere dark enough. So you don't need mushrooms to farm mushrooms. I think this is better since selfish players could prevent others from farming mushroom. If unsure, we can do a poll.

@LoneWolfHT
Copy link
Member

Not sure what you mean. Are you suggesting using this method instead of the current method with globalstep?

What I posted is how you measure how much lag it's causing, by timing how long it takes to get from the start of the globalstep to the end of it

@farooqkz
Copy link
Contributor Author

Closing as it won't be merged.

@farooqkz farooqkz closed this Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants