Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps/spdlog: fix conversion from const string to const char* #596

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

illwieckz
Copy link
Contributor

@illwieckz illwieckz commented Oct 31, 2022

Fixes:

In file included from LuxCore/deps/spdlog-1.8.0/include/spdlog/common.h:245,
                 from LuxCore/deps/spdlog-1.8.0/include/spdlog/spdlog.h:12,
                 from LuxCore/src/luxcore/luxcore.cpp:22:
LuxCore/deps/spdlog-1.8.0/include/spdlog/common-inl.h: In constructor ‘spdlog::spdlog_ex::spdlog_ex(const string&, int)’:
LuxCore/deps/spdlog-1.8.0/include/spdlog/common-inl.h:57:50: error: cannot convert ‘const string’ {aka ‘const std::__cxx11::basic_string<char>’} to ‘const char*’
   57 |     fmt::format_system_error(outbuf, last_errno, msg);
      |                                                  ^~~
      |                                                  |
      |                                                  const string {aka const std::__cxx11::basic_string<char>}

It looks like this is fixed upstream so one may prefer to update the deps instead, but this patch fixes the bug with less effort until someone looks at updating deps.

This work is courtesy of I ♥ Compute initiative funded by 🇫🇷️ rebatir.fr.

Fixes:

  error: cannot convert ‘const string’ {aka ‘const std::__cxx11::basic_string<char>’}
  to ‘const char*’

Signed-off-by: Thomas Debesse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant