Add option for stricter compiler warnings #1891

fabian-lunarg · 2024-11-27T12:06:01Z

Add a cmake-option: raise compiler-warnings level for GCC and clang
apply stricter settings for targets gfxrecon_format, gfxrecon_util, gfxrecon_graphics

first step towards #1890

ci-tester-lunarg · 2024-11-27T12:06:04Z

CI gfxreconstruct build queued with queue ID 311184.

ci-tester-lunarg · 2024-11-27T12:10:01Z

CI gfxreconstruct build # 5413 running.

ci-tester-lunarg · 2024-11-27T12:22:29Z

CI gfxreconstruct build queued with queue ID 311214.

ci-tester-lunarg · 2024-11-27T12:38:24Z

CI gfxreconstruct build queued with queue ID 311244.

ci-tester-lunarg · 2024-11-27T13:40:32Z

CI gfxreconstruct build # 5416 running.

ci-tester-lunarg · 2024-11-27T14:09:57Z

CI gfxreconstruct build # 5416 passed.

CMakeLists.txt

framework/graphics/vulkan_struct_extract_handles.cpp

ci-tester-lunarg · 2024-11-27T15:31:17Z

CI gfxreconstruct build queued with queue ID 311459.

ci-tester-lunarg · 2024-11-27T15:47:33Z

CI gfxreconstruct build # 5420 running.

ci-tester-lunarg · 2024-11-27T16:24:18Z

CI gfxreconstruct build # 5420 failed.

ci-tester-lunarg · 2024-11-27T16:31:00Z

CI gfxreconstruct build queued with queue ID 311489.

ci-tester-lunarg · 2024-11-27T16:35:01Z

CI gfxreconstruct build # 5421 running.

antonio-lunarg · 2024-11-27T16:42:33Z

framework/generated/generated_vulkan_struct_deep_copy.cpp

        reinterpret_cast<const uint8_t*>(&pointer_member) - reinterpret_cast<const uint8_t*>(&base_struct);

    // copy pointer-chain recursively
-    uint32_t copy_size = vulkan_struct_deep_copy(pointer_member, count, offset_ptr(out_data, offset));
+    uint64_t copy_size = vulkan_struct_deep_copy(pointer_member, (uint32_t)count, offset_ptr(out_data, offset));


do we prefer c++ style casting?

we do :) I'll adjust the generator

antonio-lunarg · 2024-11-27T16:42:48Z

framework/generated/vulkan_generators/vulkan_struct_deep_copy_body_generator.py

        reinterpret_cast<const uint8_t*>(&pointer_member) - reinterpret_cast<const uint8_t*>(&base_struct);

    // copy pointer-chain recursively
-    uint32_t copy_size = vulkan_struct_deep_copy(pointer_member, count, offset_ptr(out_data, offset));
+    uint64_t copy_size = vulkan_struct_deep_copy(pointer_member, (uint32_t)count, offset_ptr(out_data, offset));


antonio-lunarg · 2024-11-27T16:43:48Z

framework/graphics/vulkan_resources_util.cpp

-    const VkExtent3D scaled_extent = { static_cast<uint32_t>(std::max(extent.width * scale, 1.0f)),
-                                       static_cast<uint32_t>(std::max(extent.height * scale, 1.0f)),
-                                       static_cast<uint32_t>(std::max(extent.depth * scale, 1.0f)) };
+    const VkExtent3D scaled_extent = { static_cast<uint32_t>(std::max((float)extent.width * scale, 1.0f)),


antonio-lunarg · 2024-11-27T16:45:41Z

framework/graphics/vulkan_resources_util.cpp

@@ -1877,7 +1877,7 @@ void VulkanResourcesUtil::ReadFromImageResourceLinear(VkImage                ima
    subresource_sizes.clear();

    const double texel_size = vkuFormatTexelSizeWithAspect(format, aspect);
-    assert(texel_size == static_cast<uint64_t>(texel_size));
+    assert(texel_size == static_cast<double>(static_cast<uint64_t>(texel_size)));


GFXRECON_ASSERT and.. how about using floor(texel_size)?

damn me, I had a blackout and was searching for 'fract'

changed to use std::floor

antonio-lunarg · 2024-11-27T16:46:49Z

framework/util/driver_info.cpp

-    version[3]              = (unsigned int)((data & 0x000000000000FFFF));
+    uint16_t    version[4] = {};
+    std::string str_version;
+    version[0]  = (uint16_t)((data & 0xFFFF000000000000) >> 16 * 3);


and ... all done :)

ci-tester-lunarg · 2024-11-27T17:08:08Z

CI gfxreconstruct build # 5421 failed.

ci-tester-lunarg · 2024-11-27T17:13:03Z

CI gfxreconstruct build queued with queue ID 311512.

ci-tester-lunarg · 2024-11-27T17:15:01Z

CI gfxreconstruct build # 5422 running.

ci-tester-lunarg · 2024-11-27T17:52:23Z

CI gfxreconstruct build # 5422 passed.

ci-tester-lunarg · 2024-11-28T07:49:33Z

CI gfxreconstruct build queued with queue ID 312150.

ci-tester-lunarg · 2024-11-28T08:03:28Z

CI gfxreconstruct build # 5439 running.

panos-lunarg · 2024-11-28T08:09:06Z

CMakeLists.txt

+
+if (USE_STRICT_COMPILER_WARNINGS)
+    if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
+        SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -pedantic -Wall -Wconversion -Wextra -Werror -Wno-unused-parameter -Wno-unused-function -Wno-missing-field-initializers")


Is -Werror=shadow included with these?

yes, already had to fix at least one location with this appearing as error.

but weird, I can not spot -Wshadow in any of the lists for -Wall, -Wextra or -pedantic - https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html

ok, my bad. I only saw clang-tidy warnings. will include -Wshadow and iterate again

ok, added -Wshadow and fixed all occurances in gfxreconformat/util/graphics. thanks @panos-lunarg !

Also keep in mind the parameters I used in #1890 were mostly an experiment and not to be considered the "correct" ones or the "target". They are open to discussion and we can add or remove as we see fit

yes, totally agree. they are reasonably strict and a great starting point, but subject to some iteration. -Wall and -Wextra are already a huge leap, we even apply -pedantic atm. depending on how much work it causes we can gradually rollback the exceptions -Wno-unused-parameter -Wno-unused-function -Wno-missing-field-initializers

ci-tester-lunarg · 2024-11-28T08:40:02Z

CI gfxreconstruct build # 5439 failed.

ci-tester-lunarg · 2024-11-28T08:41:24Z

CI gfxreconstruct build queued with queue ID 312194.

ci-tester-lunarg · 2024-11-28T09:07:06Z

CI gfxreconstruct build queued with queue ID 312200.

ci-tester-lunarg · 2024-11-28T09:13:31Z

CI gfxreconstruct build queued with queue ID 312202.

…rgets

ci-tester-lunarg · 2024-11-28T10:51:35Z

CI gfxreconstruct build queued with queue ID 312279.

ci-tester-lunarg · 2024-11-28T12:31:19Z

CI gfxreconstruct build # 5446 running.

ci-tester-lunarg · 2024-11-28T13:10:01Z

CI gfxreconstruct build # 5446 passed.

fabian-lunarg requested a review from panos-lunarg November 27, 2024 12:06

fabian-lunarg force-pushed the fabian_stricter_compiler_warnings_guarded branch from 0bda28c to 039a7dc Compare November 27, 2024 12:22

fabian-lunarg requested a review from bradgrantham-lunarg November 27, 2024 12:22

fabian-lunarg force-pushed the fabian_stricter_compiler_warnings_guarded branch from 039a7dc to 8bf21c2 Compare November 27, 2024 12:38

fabian-lunarg self-assigned this Nov 27, 2024

antonio-lunarg reviewed Nov 27, 2024

View reviewed changes

CMakeLists.txt Show resolved Hide resolved

framework/graphics/vulkan_struct_extract_handles.cpp Outdated Show resolved Hide resolved

antonio-lunarg reviewed Nov 27, 2024

View reviewed changes

fabian-lunarg force-pushed the fabian_stricter_compiler_warnings_guarded branch from 85fe2eb to 3729798 Compare November 28, 2024 07:49

panos-lunarg reviewed Nov 28, 2024

View reviewed changes

fabian-lunarg force-pushed the fabian_stricter_compiler_warnings_guarded branch from 0dde75d to 7ee61b8 Compare November 28, 2024 09:07

fabian-lunarg added 5 commits November 28, 2024 11:41

Add option to use a stricter compiler-warning level, default OFF

b9bc2df

Apply stricter compiler warnings for gfxrecon_format|util|graphics ta…

f1f8cb9

…rgets

review comments

9d2bf9a

Add missing -Wshadow flag, enforce for format/util/graphics

22aa0f6

Fight against clang-format-version differences

8b843d5

fabian-lunarg force-pushed the fabian_stricter_compiler_warnings_guarded branch from 77884ec to 8b843d5 Compare November 28, 2024 10:51

Add option for stricter compiler warnings #1891

Are you sure you want to change the base?

Add option for stricter compiler warnings #1891

Conversation

fabian-lunarg commented Nov 27, 2024 • edited Loading

ci-tester-lunarg commented Nov 27, 2024

ci-tester-lunarg commented Nov 27, 2024

ci-tester-lunarg commented Nov 27, 2024

ci-tester-lunarg commented Nov 27, 2024

ci-tester-lunarg commented Nov 27, 2024

ci-tester-lunarg commented Nov 27, 2024

ci-tester-lunarg commented Nov 27, 2024

ci-tester-lunarg commented Nov 27, 2024

ci-tester-lunarg commented Nov 27, 2024

ci-tester-lunarg commented Nov 27, 2024

ci-tester-lunarg commented Nov 27, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ci-tester-lunarg commented Nov 27, 2024

ci-tester-lunarg commented Nov 27, 2024

ci-tester-lunarg commented Nov 27, 2024

ci-tester-lunarg commented Nov 27, 2024

ci-tester-lunarg commented Nov 28, 2024

ci-tester-lunarg commented Nov 28, 2024

panos-lunarg Nov 28, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fabian-lunarg Nov 28, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ci-tester-lunarg commented Nov 28, 2024

ci-tester-lunarg commented Nov 28, 2024

ci-tester-lunarg commented Nov 28, 2024

ci-tester-lunarg commented Nov 28, 2024

ci-tester-lunarg commented Nov 28, 2024

ci-tester-lunarg commented Nov 28, 2024

ci-tester-lunarg commented Nov 28, 2024

fabian-lunarg commented Nov 27, 2024 •

edited

Loading

panos-lunarg Nov 28, 2024 •

edited

Loading

fabian-lunarg Nov 28, 2024 •

edited

Loading