Add sparse image and buffer support #1877
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current trim handling for buffers and images does not support sparse buffers or sparse images. It only allows one image or buffer binding to a single memory range of a single memory object. As a result, it cannot manage sparse resources, which has led to missing asset issues in trim trace for some titles that utilize sparse resources. This commit introduces support for sparse buffers and sparse images (using opaque memory binding only), effectively resolving the missing asset issue. Originally by Ming Zheng <[email protected]>
|
CI gfxreconstruct build queued with queue ID 305787. |
|
CI gfxreconstruct build # 5350 running. |
|
CI gfxreconstruct build # 5350 passed. |
| { | ||
| if (IsCaptureModeTrack() && (result == VK_SUCCESS) && (pCreateInfo != nullptr)) | ||
| { | ||
| assert(state_tracker_ != nullptr); |
There was a problem hiding this comment.
assert -> GFXRECON_ASSERT
| @@ -816,6 +920,50 @@ class VulkanCaptureManager : public ApiCaptureManager | |||
| } | |||
| } | |||
|
|
|||
| void PostProcess_vkCreateBuffer(VkResult result, | |||
| VkDevice device, | |||
| const VkBufferCreateInfo* pCreateInfo, | |||
There was a problem hiding this comment.
Do we want snake case here?
| { | ||
| if (IsCaptureModeTrack() && (result == VK_SUCCESS) && (pCreateInfo != nullptr)) | ||
| { | ||
| assert(state_tracker_ != nullptr); |
| @@ -1380,6 +1528,7 @@ class VulkanCaptureManager : public ApiCaptureManager | |||
| std::unique_ptr<VulkanStateTracker> state_tracker_; | |||
| HardwareBufferMap hardware_buffers_; | |||
| std::mutex deferred_operation_mutex; | |||
| std::mutex sparse_resource_mutex; | |||
There was a problem hiding this comment.
How about moving the comment in PostProcess_vkQueueBindSparse here?
// In default mode, the capture manager uses a shared mutex to capture every API function. As a result,
// multiple threads may access the sparse resource maps concurrently. Therefore, we use a dedicated mutex
// for write access to these maps.
| @@ -1361,7 +1361,7 @@ void VulkanStateWriter::ProcessBufferMemory(const vulkan_wrappers::DeviceWrapper | |||
| const uint8_t* bytes = nullptr; | |||
| std::vector<uint8_t> data; | |||
|
|
|||
| assert((buffer_wrapper != nullptr) && (memory_wrapper != nullptr)); | |||
| assert(buffer_wrapper != nullptr); | |||
There was a problem hiding this comment.
ditto, and a few lines down
| const vulkan_wrappers::DeviceWrapper* device_wrapper = wrapper->bind_device; | ||
| const VulkanDeviceTable* device_table = &device_wrapper->layer_table; | ||
|
|
||
| assert((device_wrapper != nullptr) && (device_table != nullptr)); |
| encoder_.EncodeEnumValue(VK_SUCCESS); | ||
| const vulkan_wrappers::DeviceWrapper* device_wrapper = wrapper->bind_device; | ||
| const VulkanDeviceTable* device_table = &device_wrapper->layer_table; | ||
| assert((device_wrapper != nullptr) && (device_table != nullptr)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current trim handling for buffers and images does not support sparse buffers or sparse images. It only allows one image or buffer binding to a single memory range of a single memory object. As a result, it cannot manage sparse resources, which has led to missing asset issues in trim trace for some titles that utilize sparse resources. This commit introduces support for sparse buffers and sparse images (using opaque memory binding only), effectively resolving the missing asset issue.
Originally by Ming Zheng [email protected]