Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed improvement when sending large buffers via CBOR #4

Closed
wants to merge 1 commit into from

Conversation

SoylentGraham
Copy link

~230ms to ~21ms (using example 3mb quilts)

I guess it's possible that < 2048 (from previous work chrome seems to store typed array pages at 2kb) might be better with a for loop, than allocating a new view

~230ms to ~21ms (using example 3mb quilts)

I guess it's possible that < 2048 (from previous work chrome seems to store typed array pages at 2kb) might be better with a for loop, than allocating a new view
@alxdncn
Copy link
Contributor

alxdncn commented May 19, 2021

HI @SoylentGraham, thanks for submitting this! We're in the midst of a few other projects but will review this as soon as we get a moment.

@SoylentGraham
Copy link
Author

SoylentGraham commented May 19, 2021

Given this line isn't in src/HoloPlayCore.js, it's probably supposed to be a change in a dependency... but not sure which one :) (Keeping dist/compiled files in repository's is a silly habit of packages IMO :)
But would be worth looking into (I'm trying to work out the feasibility of streaming to the service)

@SoylentGraham
Copy link
Author

aha, I'm not the only one who's spotted this;
paroga/cbor-js#23

@SoylentGraham
Copy link
Author

Not fast enough? :)

@BryanChrisBrown
Copy link
Contributor

ah misclick sorry 😅

I'll test this out and see if we can merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants