fix: add missing insets in modals and below section selectors (#121)

* fix: add bottom padding in bottom sheets * fix: add padding in filtered contents (bookmarks, votes, moderated)
LiveFastEatTrashRaccoon · Nov 23, 2024 · abb5a81 · abb5a81
1 parent 0eafb69
commit abb5a81
Show file tree

Hide file tree

Showing 7 changed files with 20 additions and 6 deletions.
diff --git a/...tlin/com/livefast/eattrash/raccoonforlemmy/core/commonui/modals/CustomModalBottomSheet.kt b/...tlin/com/livefast/eattrash/raccoonforlemmy/core/commonui/modals/CustomModalBottomSheet.kt
@@ -61,7 +61,9 @@ fun CustomModalBottomSheet(
             onSelected?.invoke(null)
         },
     ) {
-        Column {
+        Column(
+            modifier = Modifier.padding(bottom = Spacing.xs),
+        ) {
             Text(
                 modifier = Modifier.fillMaxWidth(),
                 textAlign = TextAlign.Center,

diff --git a/...lin/com/livefast/eattrash/raccoonforlemmy/core/commonui/modals/SelectNumberBottomSheet.kt b/...lin/com/livefast/eattrash/raccoonforlemmy/core/commonui/modals/SelectNumberBottomSheet.kt
@@ -89,7 +89,9 @@ fun SelectNumberBottomSheet(
             onSelected?.invoke(null)
         },
     ) {
-        Column {
+        Column(
+            modifier = Modifier.padding(bottom = Spacing.xs),
+        ) {
             Text(
                 modifier = Modifier.fillMaxWidth(),
                 textAlign = TextAlign.Center,

diff --git a/...in/kotlin/com/livefast/eattrash/raccoonforlemmy/core/commonui/modals/SliderBottomSheet.kt b/...in/kotlin/com/livefast/eattrash/raccoonforlemmy/core/commonui/modals/SliderBottomSheet.kt
@@ -6,6 +6,7 @@ import androidx.compose.foundation.layout.WindowInsets
 import androidx.compose.foundation.layout.fillMaxWidth
 import androidx.compose.foundation.layout.height
 import androidx.compose.foundation.layout.navigationBars
+import androidx.compose.foundation.layout.padding
 import androidx.compose.material3.Button
 import androidx.compose.material3.ExperimentalMaterial3Api
 import androidx.compose.material3.MaterialTheme
@@ -50,7 +51,9 @@ fun SliderBottomSheet(
             onSelected?.invoke(null)
         },
     ) {
-        Column {
+        Column(
+            modifier = Modifier.padding(bottom = Spacing.xs),
+        ) {
             Text(
                 modifier = Modifier.fillMaxWidth(),
                 textAlign = TextAlign.Center,

diff --git a/...Main/kotlin/com/livefast/eattrash/raccoonforlemmy/core/commonui/modals/SortBottomSheet.kt b/...Main/kotlin/com/livefast/eattrash/raccoonforlemmy/core/commonui/modals/SortBottomSheet.kt
@@ -67,7 +67,9 @@ fun SortBottomSheet(
             onSelected?.invoke(null)
         },
     ) {
-        Column {
+        Column(
+            modifier = Modifier.padding(bottom = Spacing.xs),
+        ) {
             var level by remember { mutableStateOf<SortBottomSheetLevel>(SortBottomSheetLevel.Main) }
             Crossfade(
                 targetState = level,

diff --git a/...lin/com/livefast/eattrash/raccoonforlemmy/unit/filteredcontents/FilteredContentsScreen.kt b/...lin/com/livefast/eattrash/raccoonforlemmy/unit/filteredcontents/FilteredContentsScreen.kt
@@ -333,6 +333,7 @@ class FilteredContentsScreen(
                     item {
                         if (!uiState.isPostOnly) {
                             SectionSelector(
+                                modifier = Modifier.padding(vertical = Spacing.s),
                                 titles =
                                     listOf(
                                         LocalStrings.current.profileSectionPosts,

diff --git a/...in/com/livefast/eattrash/raccoonforlemmy/unit/manageaccounts/ManageAccountsBottomSheet.kt b/...in/com/livefast/eattrash/raccoonforlemmy/unit/manageaccounts/ManageAccountsBottomSheet.kt
@@ -80,7 +80,9 @@ fun ManageAccountsBottomSheet(
             onDismiss?.invoke(false)
         },
     ) {
-        Column {
+        Column(
+            modifier = Modifier.padding(bottom = Spacing.xs),
+        ) {
             Text(
                 modifier = Modifier.fillMaxWidth(),
                 textAlign = TextAlign.Center,

diff --git a/...in/com/livefast/eattrash/raccoonforlemmy/unit/selectinstance/SelectInstanceBottomSheet.kt b/...in/com/livefast/eattrash/raccoonforlemmy/unit/selectinstance/SelectInstanceBottomSheet.kt
@@ -108,7 +108,9 @@ fun SelectInstanceBottomSheet(
             onSelected?.invoke(null)
         },
     ) {
-        Column {
+        Column(
+            modifier = Modifier.padding(bottom = Spacing.xs),
+        ) {
             Box(
                 modifier = Modifier.fillMaxWidth().padding(top = Spacing.s),
             ) {