Refactored Image Class: Addressed Complex Conditional and Eliminated Duplicate Code in getInstance Methods

[samruddhithakor]

Description of the new Feature/Bugfix

1. Complex Conditional (True Positive):

• Project Name: OpenPDF
• Package Name: com.lowagie.text
• Type Name: Image
• Method Name: getInstance
• Cause of the Smell:
  A complex conditional at line 569 (c1 == 'M' && c2 == 'M' && c3 == 0 && c4 == 42) uses multiple logical operators and hardcoded values, reducing readability and increasing the risk of errors.
• Fix:
  Introduced named constants and helper methods to simplify the logic and improve maintainability.

2. Duplicate Code (False Negative):

• Project Name: OpenPDF
• Smell: Duplicate Code
• Missed Case:
  The methods getInstance(URL url) and getInstance(byte[] imgb) shared identical logic for reading image data and identifying image types using magic numbers.
• Fix:
  Extracted the shared logic into a utility function, loadImageFromHeader.
  This addresses the DRY (Don't Repeat Yourself) principle, reducing maintenance overhead and ensuring consistency.

Unit tests for Refactoring

• Unit tests for getInstance(URL url) and getInstance(byte[] imgb) confirm shared logic without breaking functionality.
• Unit tests validate the refactored complex conditional logic.

Compatibilities Issues

1. Complex Conditional:

• No breaking changes; the logic is refactored into helper methods for better readability.

2. Duplicate Code:

• Backward compatibility is maintained with no changes to method signatures or behavior.

Your real name

Samruddhi Dharmeshkumar Thakor

Testing details

1. Run mvn clean compile to ensure the project compiles without errors.
2. Execute mvn test to verify all unit tests pass.

[sonarcloud]

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud