Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring endorsement related code #830

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

abonnaudet-ledger
Copy link
Member

Description

Refactoring endorsements related code

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.49%. Comparing base (e8f68a6) to head (87ff43c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #830   +/-   ##
=======================================
  Coverage   35.49%   35.49%           
=======================================
  Files          13       13           
  Lines        1606     1606           
=======================================
  Hits          570      570           
  Misses       1036     1036           
Flag Coverage Δ
unittests 35.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ENDORSEMENT_revoke syscall returns a bolos_err_t instead of a
bolos_bool_t
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants