Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cx_math_is_zero run in constant time #823

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Make cx_math_is_zero run in constant time #823

merged 1 commit into from
Nov 14, 2024

Conversation

bigspider
Copy link
Contributor

Description

The current implementation cx_math_is_zero does not run in constant time, but it's not documented; this could lead to vulnerabilities if used in cryptographic code in apps.

This PR replaces it with a constant time implementation to avoid any such risks.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.49%. Comparing base (98eaa57) to head (fa3f9b8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #823   +/-   ##
=======================================
  Coverage   35.49%   35.49%           
=======================================
  Files          13       13           
  Lines        1606     1606           
=======================================
  Hits          570      570           
  Misses       1036     1036           
Flag Coverage Δ
unittests 35.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bigspider bigspider merged commit fe9d203 into master Nov 14, 2024
189 checks passed
@bigspider bigspider deleted the is_zero branch November 14, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants