Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIVE-13290] New Stax visual asset integration #8568

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

jiyuzhuang
Copy link
Contributor

@jiyuzhuang jiyuzhuang commented Dec 2, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@jiyuzhuang jiyuzhuang added the live-devices Device team label label Dec 2, 2024
@jiyuzhuang jiyuzhuang self-assigned this Dec 2, 2024
@jiyuzhuang jiyuzhuang requested review from a team as code owners December 2, 2024 15:41
Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 3:53pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 3:53pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 3:53pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 3:53pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Dec 2, 2024
@jiyuzhuang jiyuzhuang force-pushed the LIVE-13290-new-stax-visual-asset-integration branch 2 times, most recently from d651f06 to a86023b Compare December 2, 2024 15:51
@live-github-bot live-github-bot bot removed the mobile Has changes in LLM label Dec 2, 2024
@jiyuzhuang jiyuzhuang marked this pull request as draft December 2, 2024 15:52
@jiyuzhuang jiyuzhuang force-pushed the LIVE-13290-new-stax-visual-asset-integration branch from a86023b to 582a468 Compare December 2, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD live-devices Device team label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants