feat: Use listenToKnownDevices from DMK #8566
Open
+194
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
valpinkman
force-pushed
the
feat/dsdk-508-listen-known-devices
branch
from
8c5771b
to
ad1c9a7
Compare
valpinkman
force-pushed
the
feat/dsdk-508-listen-known-devices
branch
from
ad1c9a7
to
facdfe4
Compare
valpinkman
force-pushed
the
feat/dsdk-508-listen-known-devices
branch
from
facdfe4
to
b09b75e
Compare
Comment on lines
14
to
16
| const store = useStore<State>(); | ||
| const localOverrides = overriddenFeatureFlagsSelector(store.getState()); | ||
| const ldmkFeatureFlag = getFeature({ key: "ldmkTransport", localOverrides }); |
There was a problem hiding this comment.
[SHOULD] Here you can just do const ldmkFeatureFlag = useFeature("ldmkTransport") since you're in a react context, with the FF provider & the store at the root of the app, the overrides will already be computed.
This logic was needed in live-common-setup.ts because it's not in a react context.
| useEffect(() => { | ||
| let sub: Subscription; | ||
| function syncDevices() { | ||
| const devices: { [key: string]: boolean } = {}; | ||
| const devices: { [key: string]: boolean } = {}; |
There was a problem hiding this comment.
[COULD] As we saw this variable is unused, it can be removed.
| registerTransportModule({ | ||
| id: "sdk", | ||
| open: (_id: string, timeoutMs?: number, context?: TraceContext) => { | ||
| if (!ldmkFeatureFlag().enabled) return; |
There was a problem hiding this comment.
[SHOULD] also ensure that we return undefined in case we're using a vault device, or a speculos emulator, a proxy etc. as they are not yet supported in the DMK.
valpinkman
force-pushed
the
feat/dsdk-508-listen-known-devices
branch
from
b09b75e
to
0322fd5
Compare
ofreyssinet-ledger
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Update
useListenToHidDevicesto be able to rely on the DMKlistenToKnownDevices()when the feature flag is on.Also update the way we register the transports so everything is available at any time (but the
openon the LiveDMKTransport only works when FF is on)Changed the default verbosity on the DMK Logger.
❓ Context
🧐 Checklist for the PR Reviewers