FIX/LIVE-15117: exchange.swap does not have up-to-date accounts list when attempting to swap with newly created account. #8564
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
live-github-bot
bot
added
desktop
| @@ -55,6 +55,10 @@ import { registerTransportModules } from "~/renderer/live-common-setup"; | |||
| const rootNode = document.getElementById("react-root"); | |||
| const TAB_KEY = 9; | |||
|
|
|||
| export const store = createStore({ | |||
There was a problem hiding this comment.
Are you sure it does not create a side effect to change where we create the store, please?
There was a problem hiding this comment.
As far as I can tell this does not create any side effects and just moves the creation of the store outside of the init function to allow access to the store directly.
There was a problem hiding this comment.
There is a side effect that you cannot reset the store by just calling init again
Not sure how much it impacts LLD but I suppose that it would have some risk with hot reloading in dev
There was a problem hiding this comment.
Is this change necessary ?
It doesn't seem correct to init the rest and not this in the function
| function getAccounts() { | ||
| return flattenAccountsSelector(store.getState()); | ||
| } |
There was a problem hiding this comment.
It's quite strange to do that directly instead of using a the selector with useSelector
It's seems we're not addressing the root cause of the issue, a change to the accounts should be reflected to the handlers
✅ Checklist
npx changesetwas attached.📝 Description
This was because the
exchangeHandlersaccounts param did not get updated when accounts were changed. Instead this PR proposes passing a getter function that will instead grab the users currents accounts when the function is run.❓ Context
https://ledgerhq.atlassian.net/browse/LIVE-15117
🧐 Checklist for the PR Reviewers