Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(LIVE-14855): manually instantiate the account sidebar when swap triggers custom.requestAccount #8537

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

feat(LIVE-14855): manually instantiate the account sidebar when swap triggers custom.requestAccount #8537

wants to merge 6 commits into from
+94 −4

Conversation

Couto
Copy link
Contributor

@Couto Couto commented Nov 29, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

In order to trigger custom analytic events, when the user picks a currency and account in the Sidebar, manually start the sidebar with custom options, whenever the swap-live app triggers the custom.requestAccount method on the Wallet API

Related PR: https://github.com/LedgerHQ/swap-live-app/pull/476

Screen.Recording.2024-11-29.at.09.00.12.mov

❓ Context

https://ledgerhq.atlassian.net/browse/LIVE-14855

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Couto Couto requested review from a team as code owners November 29, 2024 08:56
@vercel Vercel
Copy link

vercel bot commented Nov 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 11:19am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 11:19am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 11:19am
web-tools ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 11:19am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Nov 29, 2024
CremaFR
CremaFR previously approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@CremaFR CremaFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

kallen-ledger
kallen-ledger previously approved these changes Nov 29, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kallen-ledger kallen-ledger kallen-ledger approved these changes

@LucasWerey LucasWerey LucasWerey approved these changes

@liviuciulinaru liviuciulinaru liviuciulinaru approved these changes

@CremaFR CremaFR CremaFR approved these changes

Assignees

@Couto Couto

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Couto @CremaFR @liviuciulinaru @LucasWerey @kallen-ledger