Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/LIVE-10693]: implement custom methods for ledger live mobile #8531

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

kallen-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Implement wallet api custom methods to allow swap live app to interface with ledger live mobile.

Added the following custom method handlers:

  • custom.getFee
  • custom.getTransactionByHash
  • custom.saveSwapToHistory
  • custom.swapRedirectToHistory

❓ Context

https://ledgerhq.atlassian.net/browse/LIVE-10693


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 28, 2024 4:37pm
native-ui-storybook ⬜️ Ignored (Inspect) Nov 28, 2024 4:37pm
react-ui-storybook ⬜️ Ignored (Inspect) Nov 28, 2024 4:37pm
web-tools ⬜️ Ignored (Inspect) Nov 28, 2024 4:37pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant