Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getNextAssertion implementation #61

Draft
wants to merge 17 commits into
base: develop
Choose a base branch
from
Draft

getNextAssertion implementation #61

wants to merge 17 commits into from

Conversation

lpascal-ledger
Copy link
Contributor

@lpascal-ledger lpascal-ledger commented Oct 31, 2024 •
edited
Loading

For now the getNextAssertion function is implemented only when:

  • transport is NFC
  • and the credentials are RKs (allowList is empty)

This PR still needs:

  • fixing the display info bugs & adapting the tests so that the screens are checked
  • checking the "NO NFC" settings disappearance when going to settings and coming back to the home page.
  • more GET_NEXT_ASSERTION tests

@lpascal-ledger lpascal-ledger force-pushed the add/getnextassertion branch 3 times, most recently from 4b5388f to 70263ff Compare October 31, 2024 11:03
@lpascal-ledger lpascal-ledger force-pushed the add/getnextassertion branch 5 times, most recently from 85263f0 to 0e522d0 Compare November 6, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xchapron-ledger xchapron-ledger xchapron-ledger left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lpascal-ledger @xchapron-ledger