Starting to switch to apt based builds #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
white238
reviewed
Dec 12, 2023
ubuntu/20.04/Dockerfile
Outdated
| ENV SPACK_ENV=/opt/env | ||
|
|
||
| RUN ./scripts/ubuntu/setup.sh && \ | ||
| ./scripts/install-cmake-binary.sh |
There was a problem hiding this comment.
Suggested change
| ./scripts/install-cmake-binary.sh | |
| ./scripts/install-cmake-binary.sh | |
white238
reviewed
Dec 12, 2023
ubuntu/clang/Dockerfile
Outdated
| && sudo apt-get clean | ||
|
|
||
| USER radiuss | ||
| WORKDIR /home/radiuss |
There was a problem hiding this comment.
Suggested change
| WORKDIR /home/radiuss | |
| WORKDIR /home/radiuss | |
The world may implode if the newline isnt there...
white238
reviewed
Dec 12, 2023
ubuntu/clang/uptodate.yaml
Outdated
Comment on lines
18
to
19
| - "15" | ||
| - "16" |
There was a problem hiding this comment.
Do these versions work without adding the the test apt repository?
https://github.com/LLNL/axom-docker/blob/main/ubuntu-22/base/generic-setup.sh#L27-L28
Also I think the exclude lines above are not right. I specifically need 14 for sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.