#146 Implement transitions alias #150
Conversation
| @@ -0,0 +1,25 @@ | |||
| tasks { | |||
There was a problem hiding this comment.
Do we need those files. I think it is the IDEA problem that it copies those files to the project root folder during tests execution (especially when those test fail).
| @@ -0,0 +1,7 @@ | |||
| # node & transitions | |||
| @@ -86,6 +87,16 @@ void expectTransitionSuccessWithNodeBThenNodeC(Vertx vertx) throws Throwable { | |||
| }, vertx); | |||
| } | |||
|
|
|||
| @Test | |||
| @DisplayName("Expect 'on' to alias 'onTransitions'") | |||
There was a problem hiding this comment.
Please add the case when we mix onTransitions and on.
Additionally please update all functional tests to use on instead od onTransitions.
|
Connected with PR: Knotx/knotx-stack#119 |
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
=========================================
Coverage 90.80% 90.80%
- Complexity 1619 1620 +1
=========================================
Files 153 153
Lines 6783 6785 +2
Branches 183 183
=========================================
+ Hits 6159 6161 +2
Misses 530 530
Partials 94 94
Continue to review full report at Codecov.
|
|
|
||
| @Test | ||
| @DisplayName("Expect 'onTransitions' to take precedence over 'on' alias") | ||
| void expectAliasToTakePrecedence(Vertx vertx) throws Throwable { |
There was a problem hiding this comment.
Or maybe we can throw some configuration exception when both on and onTransitions defined?
Description
Motivation and Context
#146
Screenshots (if appropriate)
Upgrade notes (if appropriate)
Types of changes
Checklist:
I hereby agree to the terms of the Knot.x Contributor License Agreement.