Fix clCopyImage 1D buffer images tests with use_pitches flag #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the following issues when running `clCopyImage` test with `use_pitches` flag for 1D buffer images. 1. Query device version using `CL_DEVICE_NUMERIC_VERSION` instead of `CL_DEVICE_VERSION`. Previously, using `char` may not be enough to store the return value. The change queries the version similar to `clFillImage` test binary. 2. Pass `host_ptr` to `clCreateBuffer` when creating the buffer for the 1D image. `host_ptr` may not be `nullptr` if use_pitches flag is used. Also, `buffer_flags` will contain `CL_MEM_USE_HOST_PTR` which requires a host pointer to be passed. 3. Conditionally use the `host_ptr` when calling `clCreateImage`, it will not be used with 1D image buffer. This is made to align with the spec, in which if `mem_flags` has `CL_MEM_USE_HOST_PTR` a host pointer must be present, but if the memory flag is not present, host pointer must be `nullptr`. 4. Use the correct free function `free` and `align_free` based on the allocation function that was used. Signed-off-by: Michael Rizkalla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the following issues when running
clCopyImagetest withuse_pitchesflag for 1D buffer images.CL_DEVICE_NUMERIC_VERSIONinstead ofCL_DEVICE_VERSION. Previously, usingcharmay not be enough to store the return value. The change queries the version similar toclFillImagetest binary.host_ptrtoclCreateBufferwhen creating the buffer for the 1D image.host_ptrmay not benullptrif use_pitches flag is used. Also,buffer_flagswill containCL_MEM_USE_HOST_PTRwhich requires a host pointer to be passed.host_ptrwhen callingclCreateImage, it will not be used with 1D image buffer. This is made to align with the spec, in which ifmem_flagshasCL_MEM_USE_HOST_PTRa host pointer must be present, but if the memory flag is not present, host pointer must benullptr.freeandalign_freebased on the allocation function that was used.