Added test for work-item functions with out-of-range arguments #2099
Conversation
|
|
||
| const char *outOfRangeWorkItemKernelCodeExt = | ||
| R"( | ||
| uint dimindx=get_work_dim()+1; |
There was a problem hiding this comment.
A smart compiler would still be able to prove at compile time that this dimidx is out-of-range.
If you want to be sure the compiler cannot prove that the dimidx is out-of-range, it'd be better to pass it as a kernel argument.
|
|
||
| int test_work_item_functions(cl_device_id deviceID, cl_context context, cl_command_queue queue, int num_elements) | ||
| const char *outOfRangeWorkItemKernelCodeExt11 = |
There was a problem hiding this comment.
Could we use a single kernel for this stuff, and guard the parts that are specific to newer OpenCL C versions using __OPENCL_VERSION__ or some other preprocessor mechanism? I think that would be easier to understand and maintain vs. stitching together these sample kernels with sprintf.
There was a problem hiding this comment.
Done, variants replaced with __OPENCL_VERSION__ preprocessor conditions
| kernel_source(src), max_workgroup_size(0) | ||
| {} | ||
|
|
||
| virtual cl_int SetUp(const char *kernel_source) |
There was a problem hiding this comment.
Something doesn't seem right here - we have a kernel_source member variables and a kernel_source function argument. Do we need both?
There was a problem hiding this comment.
Done, param renamed
Fixes #2005 according to task description.