New commands for profiling test #1780
Conversation
* clEnqueueMarkerWithWaitList * clEnqueueBarrierWithWaitList
gwawiork
force-pushed
the
profiling_new_cmds
branch
from
10fb494
to
eb83f66
Compare
| test_error(error, "Unable to set argument for test kernel"); | ||
|
|
||
| error = create_single_kernel_helper(context, &program, &kernel3, 1, | ||
| &test_kernel, "test1"); |
| fn(queue_with_props, 3, &events_list_set2[0], &eventEnqueueMarkerSet2); | ||
| test_error(error, "Unable to enqueue sync command"); | ||
|
|
||
| error = clWaitForEvents(1, &eventEnqueueMarkerSet2); |
There was a problem hiding this comment.
Should clWaitForEvents be switched to eventEnqueueMarkerSet1 since that's what's being checked in the following lines, the command queue is out of order, and set 1 doesn't wait for set 2 to complete? Or maybe clFinish would be more readable?
|
@lakshmih Thanks for review. Unfortunately I see some errors on our internal driver version. Until these issues will not be solved I do not plan any updates in this PR. I will let you know when it will be ready for review. |
Thank you. Could you review the focused review label and add it back when ready? |
I think I do not have permission to modify labels. |
Oh, thanks for letting me know. I removed it for now, we can add it back when ready. |
The test verifies if: