fix: column right pin ruins menu order #1019
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
column right pin pushes menu item to the bottom instead of keeping correct order
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This way it is was by design. And if we were to get rid of it, we would just simplify the code to |
|
@KevinVandy What do you recommend, which approach to go with? I am fairly new to contributing, especially in projects of this size, and also with limited knowledge to lets say performance of something (junior, 1 year work experience). This way I would love to learn from your thoughts and recommendations if I am able to contribute of any sort. |
|
This menu probably can be improved, especially for pinning. Just need to think about it a bit more. |
|
Keep us posted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
column right pin pushes menu item to the bottom instead of keeping correct order
closes #1018