API: Leave Group issue solving #27

Signior-X · 2020-03-29T08:41:35Z

Fixes #18
I have make the changes in app.py which adding the API for leaving the group. Also checked it using the postman and it is working. After deleting the data from ClubMembers table, it will return if it is success or not in JSON form.
Also added a file, to see the tables list.

Make_Tables/mysqlconnect.py

Milind712000 · 2020-03-29T14:28:11Z

app.py

@@ -20,5 +21,28 @@ def Login():
            flash('Login Unsuccessful. Invalid Email/Password')
    return render_template('login.html',title='Login | SAC Portal, IIT Mandi',form=form)

+#Example  https://host/leaveclub?userID='B19188'&clubID='C10001'
+@app.route('/leaveclub', methods = ['GET','POST'])


Make this route, POST only

It is showing method not allowed in POST, I thing it is GET, so I have make this route only GET

it will show method not allowed if you access it through browsers address bar because it only sends get request. that is meant to happen. that is why you should test api with postman

Also here i have used query params but use request body to transfer data

You have changed the route method, but you are still using query params for data tranfer

Make_Tables/showtables.py

Milind712000 · 2020-03-29T14:34:06Z

You added a new method called get_tables_list and a file called showtables
Can you justify their need.
You can link the issue you are working on in your PR using this https://github.blog/2013-01-22-closing-issues-via-commit-messages/ (useful github feature)

Signior-X · 2020-03-30T18:25:10Z

Fixes #18 I made the changes in app.py as you suggested.
Sorry, I added the showtables.py by mistake, I use it on my local machine to instantly get the schema of the tables. I added it in this commit by mistake and removed it.
I will always add a new line, learnt a new thing.
Also, that method is useless, so I deleted it.
Making the new pull request.

Signior-X · 2020-03-30T18:46:54Z

Also, please don't merge it now, I think merge it after the api of add groups and add members is created, so that they don't get disturbed to update their PR.

app.py

Milind712000 · 2020-03-30T19:15:54Z

app.py

@@ -20,5 +21,28 @@ def Login():
            flash('Login Unsuccessful. Invalid Email/Password')
    return render_template('login.html',title='Login | SAC Portal, IIT Mandi',form=form)

+#Example  https://host/leaveclub?userID='B19188'&clubID='C10001'
+@app.route('/leaveclub', methods = ['GET','POST'])


it will show method not allowed if you access it through browsers address bar because it only sends get request. that is meant to happen. that is why you should test api with postman

Milind712000 · 2020-03-30T19:18:52Z

Another thing, You don't need to commit amend or rebase everytime you make a change,
Its fine if your PR has multiple commits infact it makes it easier to see the changes that you make after each review, I'll tell you to rebase and squash once the PR is ready for merge and no more changes are required

Signior-X · 2020-03-31T08:27:12Z

Okay, I will use only postman.
Yes, I understand, what you are saying.
And one thing, thank you I am learning a lot of new things because of all this.

karanankit01 · 2020-04-03T12:29:43Z

app.py

+def leave_club():
+    data = {
+        "tablename" : "ClubMembers",
+        "userID" : request.args.get('userID'),


use request body to transfer data, instead of query parameters,
this'll allow for direct HTML form calls

yes, userstood for sure, will take care from next time in PRs
However, changing it and doing it as vipul suggested, to not take any parameter, isnted use the session value.

dheeraj135 · 2020-04-03T12:41:02Z

app.py

@@ -20,5 +21,28 @@ def Login():
            flash('Login Unsuccessful. Invalid Email/Password')
    return render_template('login.html',title='Login | SAC Portal, IIT Mandi',form=form)

+#Example  https://host/leaveclub?userID='B19188'&clubID='C10001'
+@app.route('/leaveclub', methods = ['POST'])


Not sure about this comment. @vsvipul @Milind712000 what do you think about this?
Guard this function to check whether the user is logged in. If the user is logged in we don't need to store the userid.
If you are thinking about admin functionalities, we can have a different function for that.

Ok, done, understood.
I will do this.

I will only take the clubID in the body, and take the userID from the session.

Milind712000 requested changes Mar 29, 2020

View reviewed changes

Added API: Leave Group

cf4bdd3

Signior-X force-pushed the priyam branch from 00f0f94 to cf4bdd3 Compare March 30, 2020 18:27

Milind712000 reviewed Mar 30, 2020

View reviewed changes

Changed app.py

52ecb04

karanankit01 requested changes Apr 3, 2020

View reviewed changes

dheeraj135 reviewed Apr 3, 2020

View reviewed changes

Signior-X added 2 commits April 3, 2020 20:23

Used the session data

b8e4f04

Improvements

a478362

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

API: Leave Group issue solving #27

API: Leave Group issue solving #27

Signior-X commented Mar 29, 2020 •

edited

Loading

Milind712000 Mar 29, 2020

Signior-X Mar 30, 2020

Milind712000 Mar 30, 2020

Milind712000 Mar 30, 2020

karanankit01 Apr 3, 2020

Milind712000 commented Mar 29, 2020 •

edited

Loading

Signior-X commented Mar 30, 2020

Signior-X commented Mar 30, 2020

Milind712000 Mar 30, 2020

Milind712000 commented Mar 30, 2020

Signior-X commented Mar 31, 2020 •

edited

Loading

karanankit01 Apr 3, 2020

Signior-X Apr 3, 2020

dheeraj135 Apr 3, 2020

Signior-X Apr 3, 2020

Signior-X Apr 3, 2020

API: Leave Group issue solving #27

Are you sure you want to change the base?

API: Leave Group issue solving #27

Conversation

Signior-X commented Mar 29, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Milind712000 commented Mar 29, 2020 • edited Loading

Signior-X commented Mar 30, 2020

Signior-X commented Mar 30, 2020

Choose a reason for hiding this comment

Milind712000 commented Mar 30, 2020

Signior-X commented Mar 31, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Signior-X commented Mar 29, 2020 •

edited

Loading

Milind712000 commented Mar 29, 2020 •

edited

Loading

Signior-X commented Mar 31, 2020 •

edited

Loading