Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add voting and registration solidity file #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vishesh-soni
Copy link
Collaborator

Two files added

voting.sol contains code for taking input of nominee information, checking current registration state, changing registration state, and viewing details of the nominees.

votecount.sol contains code for taking input of candidate vote, checking current voting state, changing voting state, and viewing total vote counts of nominees.

@harnaman-hk
Copy link
Collaborator

harnaman-hk commented Feb 9, 2022

Good start!
A few comments:

  1. Replace index with a more meaningful variable name in Voting.sol
  2. The _id for votecount in votecount.sol should be corresponding to a candidate in voting.sol, is this planned for future commits?
  3. We can merge Voting.sol and Vote.sol @GarvitV957 @vishesh-soni
  4. Is bin not auto-generated at compilation?

If points 2 and 3 are targeted for future commits, we can look to merge this one.

@vishesh-soni
Copy link
Collaborator Author

No, _id is mapping to the nominee for fetching vote-count of nominees.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants