Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same plotlyjs version number for all imports #480

Merged

Conversation

fonsp
Copy link
Contributor

@fonsp fonsp commented Jan 5, 2024

This PR makes sure that the same version of the plotlyjs web asset is used for all imports: through artifact or through CDN.

This also adds _js_version and _js_path as public API: this means other packages can depend on PlotlyJS.jl to get the plotly.min.js asset. Used in JuliaPlots/Plots.jl#4862

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (43d38e9) 37.50% compared to head (b2532bc) 36.51%.
Report is 5 commits behind head on master.

Files Patch % Lines
src/PlotlyJS.jl 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
- Coverage   37.50%   36.51%   -0.99%     
==========================================
  Files           4        4              
  Lines         288      293       +5     
==========================================
- Hits          108      107       -1     
- Misses        180      186       +6     
Flag Coverage Δ
unittests 36.51% <50.00%> (-0.99%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeastyBlacksmith BeastyBlacksmith merged commit 9fce8dd into JuliaPlots:master Jan 15, 2024
4 of 8 checks passed
@fonsp fonsp deleted the fix-plotly-js-version-number branch January 15, 2024 11:48
@fonsp
Copy link
Contributor Author

fonsp commented Jan 15, 2024

Thanks! Could you also make a release? Then we can work on JuliaPlots/Plots.jl#4862

@fonsp
Copy link
Contributor Author

fonsp commented Jan 23, 2024

Thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants