Fixed incorrect handling of models with no materials

JuanDiegoMontoya · Aug 2, 2024 · 430b799 · 430b799
1 parent 61ee2c8
commit 430b799
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 7 deletions.
diff --git a/src/Application.cpp b/src/Application.cpp
@@ -275,9 +275,6 @@ Application::Application(const CreateInfo& createInfo)
   glfwSetWindowPos(window, videoMode->width / 2 - windowFramebufferWidth / 2 + monitorLeft, videoMode->height / 2 - windowFramebufferHeight / 2 + monitorTop);
 
   glfwSetWindowUserPointer(window, this);
-  //glfwMakeContextCurrent(window);
-  //glfwSwapInterval(vsyncEnabled ? 1 : 0);
-  // TODO: configure vsync
 
   glfwSetCursorPosCallback(window, ApplicationAccess::CursorPosCallback);
   glfwSetCursorEnterCallback(window, ApplicationAccess::CursorEnterCallback);

diff --git a/src/Scene.cpp b/src/Scene.cpp
@@ -94,7 +94,7 @@ namespace Scene
       {
         auto& meshInstanceId = meshInstanceIds.emplace_back(renderer.RegisterMeshInstance({
           .meshGeometry = meshGeometryIds[baseMeshGeometryIndex + meshIndex],
-          .material     = materialIds[baseMaterialIndex + materialIndex],
+          .material     = materialIds[materialIndex.has_value() ? baseMaterialIndex + *materialIndex : 0],
         }));
 
         auto meshId = meshIds.emplace_back(renderer.SpawnMesh(meshInstanceId));

diff --git a/src/SceneLoader.cpp b/src/SceneLoader.cpp
@@ -1026,11 +1026,11 @@ namespace Utility
               rawMeshIndex = it->second;
             }
 
-            auto materialId = primitive.materialIndex.has_value() ? uint32_t(primitive.materialIndex.value()) : 0;
+            auto materialId = primitive.materialIndex;
 
             if (skipMaterials)
             {
-              materialId = 0;
+              materialId = std::nullopt;
             }
 
             node->meshes.emplace_back(rawMeshIndex, materialId);

diff --git a/src/SceneLoader.h b/src/SceneLoader.h
@@ -36,7 +36,7 @@ namespace Utility
     struct MeshIndices
     {
       size_t meshIndex;
-      size_t materialIndex;
+      std::optional<size_t> materialIndex;
     };
     std::vector<MeshIndices> meshes;
     std::optional<Render::GpuLight> light; // TODO: hold a light without position/direction type safety