vuln-fix: Temporary Directory Hijacking or Information Disclosure

This fixes either Temporary Directory Hijacking, or Temporary Directory Local Information Disclosure. Weakness: CWE-379: Creation of Temporary File in Directory with Insecure Permissions Severity: High CVSSS: 7.3 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.UseFilesCreateTempDirectory) Reported-by: Jonathan Leitschuh <[email protected]> Signed-off-by: Jonathan Leitschuh <[email protected]> Bug-tracker: JLLeitschuh/security-research#10 Co-authored-by: Moderne <[email protected]>
JLLeitschuh · Jul 27, 2022 · 68c851e · 68c851e
1 parent 6c3cab0
commit 68c851e
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/src/main/java/tahrir/tools/TrUtils.java b/src/main/java/tahrir/tools/TrUtils.java
@@ -17,6 +17,7 @@
 
 import java.io.*;
 import java.lang.reflect.Type;
+import java.nio.file.Files;
 import java.security.interfaces.RSAPrivateKey;
 import java.security.interfaces.RSAPublicKey;
 import java.util.Random;
@@ -162,13 +163,7 @@ public static BroadcastMessage getBroadcastMessageFrom(TrNode node, UserIdentity
 		public static File createTempDirectory() throws IOException {
 			final File temp;
 
-			temp = File.createTempFile("temp", Long.toString(System.nanoTime()));
-
-			if (!(temp.delete()))
-				throw new IOException("Could not delete temp file: " + temp.getAbsolutePath());
-
-			if (!(temp.mkdir()))
-				throw new IOException("Could not create temp directory: " + temp.getAbsolutePath());
+			temp = Files.createTempDirectory("temp" + Long.toString(System.nanoTime())).toFile();
 
 			return (temp);
 		}