vuln-fix: Temporary Directory Hijacking or Information Disclosure

This fixes either Temporary Directory Hijacking, or Temporary Directory Local Information Disclosure. Weakness: CWE-379: Creation of Temporary File in Directory with Insecure Permissions Severity: High CVSSS: 7.3 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.UseFilesCreateTempDirectory) Reported-by: Jonathan Leitschuh <[email protected]> Signed-off-by: Jonathan Leitschuh <[email protected]> Bug-tracker: JLLeitschuh/security-research#10 Co-authored-by: Moderne <[email protected]>
JLLeitschuh · Jul 27, 2022 · d3a300a · d3a300a
1 parent c191bb1
commit d3a300a
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/test/java/org/jboss/test/util/test/protocol/FileURLConnectionTestCase.java b/src/test/java/org/jboss/test/util/test/protocol/FileURLConnectionTestCase.java
@@ -24,6 +24,7 @@
 import java.io.InputStreamReader;
 import java.net.URL;
 import java.net.URLConnection;
+import java.nio.file.Files;
 
 import junit.framework.TestCase;
 
@@ -95,11 +96,9 @@ public void testDirectoryListing() throws Exception
       //   TMPDIR/testDirectoryList39558
       //   TMPDIR/testDirectoryList39558/test.txt
       //   TMPDIR/testDirectoryList39558/test.dir
-      File rootDir = File.createTempFile("testDirectoryList", "");
+      File rootDir = Files.createTempDirectory("testDirectoryList").toFile();
       try
       {
-         rootDir.delete();
-         rootDir.mkdir();
          System.out.println(rootDir);
          File tmpFile = new File(rootDir, "test.txt");
          tmpFile.createNewFile();