Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show project name when editing COMMIT_EDITMSG #24

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

l-zeuch
Copy link
Contributor

@l-zeuch l-zeuch commented Jul 11, 2024

Description of changes

Show the project name when editing a COMMIT_EDITMSG file. Formerly, we
changed the working directory to the path of the file being edited,
which is undesirable when committing changes on a project tracked in Git.

Relevant Issues

N/A

CC Maintainers

@IogaMaster


Addendum:

I'm not sure if this change is also desirable—I'm fine with maintaining
my own patchset if it isn't accepted by the general userbase.
There's still a warning emitted by luacheck, but it isn't relevant to
this change, therefore I didn't bother to fix it, though it seems to be
rather trivial.

Show the project name when editing a COMMIT_EDITMSG file. Formerly, we
changed the working directory to the path of the file being edited,
which is undesirable when committing changes on a project tracked in
Git.

Signed-off-by: Luca Zeuch <[email protected]>
@l-zeuch
Copy link
Contributor Author

l-zeuch commented Jul 31, 2024

Hey @IogaMaster, I hope you're doing fine.
Just wanted to let you know that this is still awaiting your review, perhaps it got lost in a mountain of notifications.

Copy link
Owner

@IogaMaster IogaMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do some testing soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants