Add a quickstart library file #25
Conversation
Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
didcomm_messaging/quickstart.py
Outdated
| async def fetch_relayed_messages( | ||
| dmp: DIDCommMessaging, | ||
| my_did: DID, | ||
| relay_did: DID, | ||
| callback: Callable[[Message], Awaitable[None]] = None, | ||
| ) -> List[Message]: |
There was a problem hiding this comment.
Subtle issue, our mediator will always respond as though return route had been set on the inbound message. However, this is not strictly correct behavior. These messages should include return route. And we should probably make assertions about the inclusion of return route in the mediator's handlers.
There was a problem hiding this comment.
I have added "return-route": "all" to all messages by default to the quickstart
| [ | ||
| { | ||
| "type": "DIDCommMessaging", | ||
| "serviceEndpoint": { | ||
| "uri": relay_did, | ||
| "accept": ["didcomm/v2"], | ||
| }, | ||
| } | ||
| ], |
There was a problem hiding this comment.
Most of this is static; should we just have a parameter that takes the relay_did and makes the rest of that in the generate method?
There was a problem hiding this comment.
If we have the generate method in did:peer:N allow either a DID or a service structure, I could agree. However, showing the structure here does also provide the benefit of teaching people that "this is what a basic service block looks like when you generate a DID"
There was a problem hiding this comment.
I think we get that "this is what it looks like" by having the generate method nearby in the quickstart module (which it is).
There was a problem hiding this comment.
Since the generate method is defined elsewhere, I have created two issues regarding this change:
- Allow DID to be provided in-place of a service list decentralized-identity/did-peer-2#4
- Add "user-friendly" generate function decentralized-identity/did-peer-4#8
The solution should be handled in their respective projects.
Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
Adds a quickstart.py file which is intended to provide a "quick-start" for those intending to get started with this library, but may not want to know all of the nitty-gritty details quite yet. This is intended to support https://github.com/decentralized-identity/didcomm-book, making it even easier for newcomers to get started with DIDComm.