Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build,refactor,fix: migrated to newer dart,flutter version; fixed cod… #36

Merged
merged 5 commits into from
Oct 4, 2023
Merged

build,refactor,fix: migrated to newer dart,flutter version; fixed cod… #36

merged 5 commits into from
Oct 4, 2023

Conversation

dk-a-dev
Copy link
Collaborator

@dk-a-dev dk-a-dev commented Oct 4, 2023

Summary

build: migrated to flutter version 3.13.0 stable and also added null safety checks
fix and refactor: all the libraries were migrated to null-safe versions and two were changed to support existing features

This is the Issue Title

Major Changes made

  • migrated the project completely to new versions of flutter
  • slimy_card library changed with flutter_slimy_card as prev one was breaking and is not supporting newer dart versions
  • fixed errors of the http package in the project
  • changed buttons which were deprecated.
  • code optimization along with refactoring to support new versions and improve code quality.

mintbomb27
mintbomb27 reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@mintbomb27 mintbomb27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the refactor! Any particular reason to remove the .github folder? The ISSUE_TEMPLATE and PULL_REQUEST_TEMPLATE does add a proper format to the issues and PRs created. Recommend adding it back.

@dk-a-dev
Copy link
Collaborator Author

dk-a-dev commented Oct 4, 2023 •
edited
Loading

Great job on the refactor! Any particular reason to remove the .github folder? The ISSUE_TEMPLATE and PULL_REQUEST_TEMPLATE does add a proper format to the issues and PRs created. Recommend adding it back.

Added it back please re-review and merge

mintbomb27
mintbomb27 requested changes Oct 4, 2023
View reviewed changes
.github/workflows/flutter-ci.yml Outdated Show resolved Hide resolved
mintbomb27
mintbomb27 approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@mintbomb27 mintbomb27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mintbomb27 mintbomb27 merged commit 926d457 into IEEE-VIT:master Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mintbomb27 mintbomb27 mintbomb27 approved these changes

Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dk-a-dev @mintbomb27