Skip to content

Commit

Permalink
fix: specify the maximum version of requests to avoid regression
Browse files Browse the repository at this point in the history
Version `2.23.3` of the `requests` package broke our custom
`SSLHTTPAdapter`. This commit defines the maximum version of that
package, to make sure it will continue working without an issue. Note
that, this is a short term solution only. For more details see this
issue: psf/requests#6730

Signed-off-by: Norbert Biczo <[email protected]>
  • Loading branch information
pyrooka committed Jun 3, 2024
1 parent 1c20738 commit f2be943
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions ibm_cloud_sdk_core/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@
import dateutil.parser as date_parser


# pylint: disable=fixme
# TODO: revert the change in the `requirement.txt` once this class become deprecated!
class SSLHTTPAdapter(HTTPAdapter):
"""Wraps the original HTTP adapter and adds additional SSL context."""

Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
requests>=2.31.0,<3.0.0
requests>=2.31.0,<2.32.3
urllib3>=2.1.0,<3.0.0
python_dateutil>=2.8.2,<3.0.0
PyJWT>=2.8.0,<3.0.0

0 comments on commit f2be943

Please sign in to comment.