Added topology aware volume scheduling for node service #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmitRoushan
changed the title
3 tasks
wisererik
suggested changes
Aug 26, 2021
| @@ -52,6 +52,11 @@ spec: | |||
| env: | |||
| - name: CSI_ENDPOINT | |||
| value: /var/lib/csi/sockets/pluginproxy/csi.sock | |||
| - name: CSI_ESDK_NODENAME | |||
There was a problem hiding this comment.
suggest do not use ESDK in the name. keep CSI_NODENAME
There was a problem hiding this comment.
Updated environment variable name as per suggestion
| @@ -36,6 +36,12 @@ spec: | |||
| - "--containerized" | |||
| - "--driver-name=csi.huawei.com" | |||
| - "--volume-use-multipath=true" | |||
| env: | |||
| - name: CSI_ESDK_NODENAME | |||
| valueFrom: | |||
There was a problem hiding this comment.
Updated environment variable name as per suggestion
| @@ -65,6 +65,11 @@ spec: | |||
| env: | |||
| - name: CSI_ENDPOINT | |||
| value: /var/lib/csi/sockets/pluginproxy/csi.sock | |||
| - name: CSI_ESDK_NODENAME | |||
There was a problem hiding this comment.
Updated environment variable name as per suggestion
| @@ -88,6 +88,11 @@ spec: | |||
| env: | |||
| - name: CSI_ENDPOINT | |||
| value: /var/lib/csi/sockets/pluginproxy/csi.sock | |||
| - name: CSI_ESDK_NODENAME | |||
There was a problem hiding this comment.
Updated environment variable name as per suggestion
AmitRoushan
force-pushed
the
topology-node-plugin-modification
branch
from
1b765fe
to
9d5246f
Compare
AmitRoushan
force-pushed
the
topology-node-plugin-modification
branch
from
9d5246f
to
ca8a32f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The PR maintain code changes of topology aware volume scheduling for node service: